Overzealous FindBugs changes. #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kohsuke Kawaguchi » github-api #401 SUCCESS |
Charsets that are standard on the JRE are try-lookuped, bridge methods were removed and a stream that would be closed later is closed explicitly
Shredder121
force-pushed
the
findbugs-changes
branch
from
1a34053
to
5dc83cf
Compare
|
Kohsuke Kawaguchi » github-api #402 SUCCESS |
| } catch (Exception ex) { | ||
| throw new IOException("UTF-8 encoding is not supported", ex); | ||
| } | ||
| Charset charset = Charsets.UTF_8; |
There was a problem hiding this comment.
should be inlined with static import i think
There was a problem hiding this comment.
If more people agree I'll do that then.
Shall I remove the variable declaration and inline it to the method call or just convert to static import?
|
IIRC the problem with charsets was related to JVM 6. I'm not sure how Apache codecs behave there, needs to be checked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Charsets that are standard on the JRE are try-lookuped,
bridge methods were removed and a stream that would be closed later is closed explicitly